202411 #8
Draft
202411 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver 0.1.33, once_cell 1.21.3, windows-core 0.61.0; 新しいパッケージを追加: getrandom 0.3.2, r-efi 5.2.0, wasi 0.14.2+wasi-0.2.4, windows-implement 0.60.0, windows-interface 0.59.1, windows-result 0.3.2, windows-strings 0.4.0, wit-bindgen-rt 0.39.0
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Rust edition to 2024, upgrades multiple dependency versions, and refines GitHub workflow configurations.
- Updated Cargo.toml files in the main project and xtask to use the 2024 edition and newer dependency versions.
- Adjusted dependency version constraints and licensing clarifications in deny.toml and clarify.toml.
- Upgraded GitHub workflow runner versions and checkout actions, and enhanced the build matrix in build.yml.
Reviewed Changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| xtask/Cargo.toml | Changed Rust edition to 2024 and updated several dependency versions. |
| deny.toml | Updated build script allowances and bumped dependency versions. |
| clarify.toml | Expanded and refined license expressions and file mappings. |
| Cargo.toml | Upgraded edition and dependency versions, including switching to a git ref. |
| .github/workflows/*.yml | Updated runner images, checkout actions, and build matrix configurations. |
Files not reviewed (4)
- Dockerfile: Language not supported
- rust-toolchain: Language not supported
- xtask/templates/install-command.bash.txt: Language not supported
- xtask/templates/install-script.toml.txt: Language not supported
Comments suppressed due to low confidence (4)
Cargo.toml:22
- [nitpick] Consider removing the commented-out version of ac-library-rs to avoid potential confusion with the new git dependency specification.
ac-library-rs = { git = "https://github.com/rust-lang-ja/ac-library-rs", rev = "eea0b2ac6b177fc09b706b4e727b3e62e6ef30e7" }
Cargo.toml:35
- Verify that the upgrade to amplify v4.8.0 is fully compatible with the existing codebase, as version changes may bring breaking changes.
amplify = { version = "=4.8.0", features = ["c_raw", "rand", "stringly_conversions"] }
.github/workflows/typos.yml:8
- Confirm that the upgrade to ubuntu-24.04 as the runner does not introduce compatibility issues with the actions used.
runs-on: ubuntu-24.04
.github/workflows/licenses.yml:26
- Ensure that cargo-deny v0.16 does not introduce any configuration or behavior changes that may affect license checks.
run: cargo binstall cargo-deny@^0.16 --no-confirm --log-level debug
| - { target: x86_64-apple-darwin, os: macos-11 } | ||
| - { target: x86_64-apple-darwin, os: macos-12 } | ||
| - { target: x86_64-unknown-linux-gnu, os: ubuntu-20.04 } | ||
| - { target: x86_64-pc-windows-msvc, os: windows-2025 } |
There was a problem hiding this comment.
Ensure that the specified runner 'windows-2025' is available and supported by GitHub Actions to prevent build failures.
Suggested change
| - { target: x86_64-pc-windows-msvc, os: windows-2025 } | |
| - { target: x86_64-pc-windows-msvc, os: windows-2022 } |
Copilot uses AI. Check for mistakes.
…に更新; 新しいパッケージallocator-api2 0.2.21とfoldhash 0.1.5を追加; indexmapを2.9.0、petgraphを0.8.0、smallvecを1.15.0に更新; deny.tomlにZlibライセンスを追加
…2.0.101に、zerocopyを0.8.25に更新
…xmultiplyを0.3.10に更新
…4.5.38に、getrandomを0.3.3に、icu_propertiesを2.0.1に、icu_properties_dataを2.0.1に、once_cell_polyfillを1.70.1に、owo-colorsを4.2.1に、rustversionを1.0.21に、windows-coreを0.61.2に、windows-resultを0.3.4に、windows-stringsを0.4.2に更新
…を1.0.1に、hashbrownを0.15.4に、indexmapを2.10.0に、libcを0.2.174に、memchrを2.7.5に、petgraphを0.8.2に、smallvecを1.15.1に、synを2.0.104に、wasiを0.11.1に、zerocopyを0.8.26に更新
- Updated adler2 from 2.0.0 to 2.0.1 - Updated anstream from 0.6.18 to 0.6.19 - Updated anstyle from 1.0.10 to 1.0.11 - Updated anstyle-parse from 0.2.6 to 0.2.7 - Updated anstyle-query from 1.1.2 to 1.1.3 - Updated anstyle-wincon from 3.0.8 to 3.0.9 - Updated autocfg from 1.4.0 to 1.5.0 - Updated bincode from 1.3.3 to 2.0.1 and added bincode_derive 2.0.1 - Updated build-info from 0.0.40 to 0.0.41 - Updated build-info-build from 0.0.40 to 0.0.41 - Updated build-info-common from 0.0.40 to 0.0.41 - Updated bumpalo from 3.17.0 to 3.19.0 - Updated camino from 1.1.9 to 1.1.10 - Updated cargo_metadata from 0.19.2 to 0.20.0 - Updated cc from 1.2.24 to 1.2.27 - Updated clap and related packages to 4.5.40 - Updated color-eyre from 0.6.4 to 0.6.5 - Updated color-spantrace from 0.2.2 to 0.3.0 - Updated colorchoice from 1.0.3 to 1.0.4 - Updated libc from 0.2.172 to 0.2.174 - Updated rand and related packages to latest versions - Updated serde and related packages to latest versions - Updated toml and toml_edit to latest versions - Updated twox-hash from 2.1.0 to 2.1.1 - Updated zerocopy and zerocopy-derive to 0.8.26
…n, cc, clap, rustc-demangle, serde_json, toml, toml_edit, zerovecのバージョンを更新
The Windows Server 2019 image has been removed as of 2025-06-30. For more details, see actions/runner-images#12045
….22に更新し、チェックサムを修正
….7.0、libcを0.2.175、proc-macro2を1.0.101、synを2.0.106、thiserrorを2.0.15に変更
qryxip
reviewed
Sep 8, 2025
There was a problem hiding this comment.
以下のコメントは無くてよいように感じました。
- 「コンパイル時間が著しく長くなってしまう場合は無し」
- 現行の202301環境において、LTOによる問題は発生していないと結論付けられたはずなので。
- 「transitive dependenciesのライセンスについては:」
- 202301環境においてはtransitive、今で言うindirectな依存のリストをAtCoderは要求してこなかったため。今であれば不要なはず。このコメントにはbottlerocket-license-scanだけではなくcargo-denyについての言及もあるが、この言及を残したいのであればTOMLの
licenseあたりになると思います。
- 202301環境においてはtransitive、今で言うindirectな依存のリストをAtCoderは要求してこなかったため。今であれば不要なはず。このコメントにはbottlerocket-license-scanだけではなくcargo-denyについての言及もあるが、この言及を残したいのであればTOMLの
There was a problem hiding this comment.
↑ 間違えました。install-command.bash.txtの方です。
(あと、まとめて書くつもりがうっかり押し間違えた)
qryxip
reviewed
Sep 8, 2025
Comment on lines
+183
to
+187
| version_h = package | ||
| .version | ||
| .to_string() | ||
| .replace(".", "-") | ||
| .replace("+", "-"), |
There was a problem hiding this comment.
nit: Cargoの制約上バージョンはこういう省略ができるはず…なのですがCargo内部でもこういう単一化はやっていないっぽいので別にそのままでいいかもしれません。そもそもlibraryのキー名はユニークであればよさそう？
0.1.2→0.11.2.3→11.2.3-alpha.1→1.2.3-alpha.1(pre release部分は省略してはならない)1.2.3+innerlibrary-2.3.4→1(build metadata部分は常に無視してよいはず)
| }) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| let mut store = askalono::Store::new(); |
There was a problem hiding this comment.
AtCoderのテンプレートによるとライセンスのexceptionは確実に書くようにとのことでしたが、askalonoが例外規定部分を握り潰してしまうという理解でよいんでしょうか…?
jpeddicord/askalono#91
There was a problem hiding this comment.
Rust 1.75 (多分)以降package.versionは省略可能なので、削っていいかもしれません。
(省略した場合0.0.0扱い)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.